Created a GitHub Actions CI workflow. Temp rename CircleCI version #796
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the CI/CD pipeline from CircleCI to GitHub Actions. The CircleCI configuration is temporarily renamed (from config.yml to temp-rename-config.yml) to disable it while testing the new GitHub Actions workflow.
Key Changes:
- New GitHub Actions workflow created to build and test the Jekyll site
- CircleCI configuration temporarily disabled via file rename
- Both configurations maintain the same build steps: dependency installation, Jekyll build, and HTML validation with htmlproofer
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
New GitHub Actions workflow that builds the Jekyll site and runs htmlproofer tests on push to master and pull requests |
.circleci/temp-rename-config.yml |
CircleCI configuration renamed to temporarily disable it during the migration testing phase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| gem install bundler | ||
| bundle install | ||
|
|
There was a problem hiding this comment.
The bundler installation is redundant. The ruby/setup-ruby action with bundler: 2.4.17 already installs the specified bundler version. Remove the 'gem install bundler' line as it's unnecessary and could potentially install a different bundler version than specified.
| gem install bundler | |
| bundle install | |
| bundle install |
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| gem install bundler | ||
| bundle install |
There was a problem hiding this comment.
Consider adding 'bundler-cache: true' to the ruby/setup-ruby action. This will automatically cache gems based on the Gemfile.lock, significantly speeding up subsequent workflow runs. The ruby/setup-ruby action supports this feature and will handle 'bundle install' automatically when caching is enabled.
| - name: Install dependencies | |
| run: | | |
| gem install bundler | |
| bundle install | |
| bundler-cache: true | |
| - name: Install dependencies | |
| run: echo "Dependencies are installed via ruby/setup-ruby with bundler-cache" |
Trying to use GitHub Actions rather than CircleCI